Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed attributes we don't need to explicitly define. #297

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

wendigolabs
Copy link
Contributor

@wendigolabs wendigolabs commented Jan 25, 2021

The component doesn't do anything special with readOnly and onChange, so there's no reason to privilege these particular attributes in the component.

Also added some more <input /> types because they're so cool.

@wendigolabs
Copy link
Contributor Author

The story file demos these two attributes so since they're no longer specifically referenced in the component, should they be removed? Logically, they should be, since we're not demoing any of the other umpteen input attributes that aren't specifically defined in Input, but it does enrich the examples to have them...

@wendigolabs wendigolabs changed the title Removed properties we don't need to explicitly define. Removed attributes we don't need to explicitly define. Jan 25, 2021
@pixelbandito
Copy link
Contributor

The story file demos these two attributes so since they're no longer specifically referenced in the component, should they be removed? Logically, they should be, since we're not demoing any of the other umpteen input attributes that aren't specifically defined in Input, but it does enrich the examples to have them...

I hadn't considered that, good observation.
I'd think: go wild with illustrative examples in the "Examples" story, but only instrument used props in the "Overview" story.
That said, having an input without onChange sounds kinda weird even in the bare-bones overview. I don't mind leaving it in if you don't.

@wendigolabs
Copy link
Contributor Author

wendigolabs commented Feb 1, 2021

I hadn't considered that, good observation.
I'd think: go wild with illustrative examples in the "Examples" story, but only instrument used props in the "Overview" story.
That said, having an input without onChange sounds kinda weird even in the bare-bones overview. I don't mind leaving it in if you don't.

Agreed, it does make sense to leave that one (onChange) in if nothing else. So I'll do readd that, and add a few more examples.

@wendigolabs
Copy link
Contributor Author

Ok, made the discussed changes. See how this version looks.

@wendigolabs wendigolabs merged commit ed5b37d into master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants